Skip to content

FOUR-9814: Add new Default templates#5116

Merged
ryancooley merged 2 commits into
developfrom
task/FOUR-9814
Aug 9, 2023
Merged

FOUR-9814: Add new Default templates#5116
ryancooley merged 2 commits into
developfrom
task/FOUR-9814

Conversation

@estebangallego
Copy link
Copy Markdown
Contributor

@estebangallego estebangallego commented Aug 8, 2023

Issue & Reproduction Steps

This PR has been created to test the functionality of the new Templates within CI. We ran into an issue with the unitTest that may be happening based on the number of transactions needed to process the TemplateToProcessSync.

phpunit tests/Feature/Templates/Api/ProcessTemplateTest.php --filter=testTemplateToProcessSync

Solution

  • Skip testTemplateToProcessSync for now.

How to Test

  1. Please ensure that you have the Templates env variables within PM.
DEFAULT_TEMPLATE_REPO=process-templates
DEFAULT_TEMPLATE_BRANCH=develop
DEFAULT_TEMPLATE_CATEGORIES=all
  1. Wipe the database and reinstall PM. (You should see 20 templates only)
  2. Now change in the .env the default branch to DEFAULT_TEMPLATE_BRANCH=Templates-08-04-2023
  3. Please verify that we have 41 templates and that we don't have any duplicates within the templates tab.

Related Tickets & Packages

CI

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@estebangallego estebangallego changed the title DO NOT MERGE -> Test testTemplateToProcessSync FOUR-9814: Add new Default templates Aug 9, 2023
@ryancooley ryancooley merged commit a3c2056 into develop Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants